pyblueprints icon indicating copy to clipboard operation
pyblueprints copied to clipboard

add draft support to mongodb, require pymongo

Open cocoon-project opened this issue 9 years ago • 2 comments

a first shot to add mongodb as a backend needs pymongo ( add to requirements.txt ?)

cocoon-project avatar Apr 23 '15 08:04 cocoon-project

Hi @cocoon-project,

It looks good!

A couple of things:

  • The if __name__ part could use a clean up. There's a trailing print and some commented out lines that could be removed.
  • Feel free to add pymongo to requirements.txt. It's how the other supported platforms work. It'd be interesting to have optional requirements depending on the system that it's going to be used in the future.
  • You could update the README with some usage examples if you want.

Thanks for your contribution!!

escalant3 avatar Apr 27 '15 17:04 escalant3

I work on several other backends , redis , and the native python shelve library and a way to import dependencies as needed. i will propose it as soon as tested

cocoon-project avatar Apr 29 '15 11:04 cocoon-project