esalberg

What about adding a parameter that allows people to disable the ensure_packages for curl if it's causing issues (since in that case, they're managing it elsewhere in their code)? At...

Fair enough on the installed versus present - I was just going on the Puppet docs and didn't check the function: https://docs.puppet.com/puppet/latest/types/package.html#package-attribute-ensure I went ahead and retested with the following...

My guess would be that this could be implemented via a groovy script, e.g. like the one here: https://github.com/geerlingguy/ansible-role-jenkins/issues/28 However, while the password could be encrypted via Hiera eyaml, once...

Instead of jenkins_exec, maybe jenkins_script or jenkins_groovy?

FYI - It looks like the Kubernetes upstream requirement finally is being merged for k8s 1.22. Not sure when AWS will get 1.22, but hopefully then we can get a...

/remove-lifecycle rotten From: Kubernetes Triage Robot ***@***.***> Reply-To: kubernetes-sigs/aws-efs-csi-driver ***@***.***> Date: Saturday, August 21, 2021 at 10:25 AM To: kubernetes-sigs/aws-efs-csi-driver ***@***.***> Cc: Elyse Salberg ***@***.***>, Author ***@***.***> Subject: Re: [kubernetes-sigs/aws-efs-csi-driver]...

Reason for PR: we have some legacy nodes that have ext3 filesystems mounted as ext4. While we're working to convert those, we need to be able to manage the the...

My rspec is very weak - I removed it so that the Travis checks would stop failing. I tried adding this to spec/unit/puppet/provider/filesystem/lvm_spec.rb: describe "when checking existence" do it "should...

Rebased to fix the conflict.

rebased to fix conflict in README.md