Erwin Kok
Erwin Kok
I added a docker-compose file for convenience to be able to test a ping locally on your own system. However, I put it in the wrong directory (impl), thats why...
All green! 😃 I set the PR to "ready for review". If somebody can have a look... @mxinden @MarcoPolo Btw,I added a docker-compose file for convenience to be able to...
> Cool to see this happening. > > Do you know how much additional time compiling and running this adds? Almost 3 min
> It is. I had this changed locally already but apparently forgot to commit and push it as well... > > You'll need to sign the CLA for me to...
Hi @schrej , the CLA is covered now! Can you have another look?
Thanks for reviewing Mohamed (@mcbenjemaa)! Can you clarify why the secret should be re-used over clusters? So lets say I have an prod and a development cluster, they can share...
Thanks for clarifying. I assumed that the approach would be to deploy a different cluster to a different namespace (in the management cluster). So namespace"prod" manages the "prod" cluster, and...
So, there were two linting issues, both not related to my code (but I solved them anyway): - Unblocking of else branch: ``` if .... { return } else {...
Working for the same team as Robin Valk, I propose a fix by increasing the timeout to 5 minutes: https://github.com/NetApp/trident/pull/940 Note there is already exponential backoff logic in-place. However, the...