Ershad Kunnakkadan comments

Results 20 comments of


                                            Ershad Kunnakkadan

Local Development Still Requires Real AWS S3 Credentials — MinIO Not Used Despite PR #1738

We are working on that here: https://github.com/antiwork/gumroad/pull/1773 @Treata11 there are some spec failures, please feel free to send PRs to that branch if you would like.

Run Gumroad tests without secrets

@sarangsohail Thanks for the PR! Added a few [review comments](https://github.com/antiwork/gumroad/pull/1121).

Add churn chart to analytics

~Could someone please share a screenshot? I can see the images in the description, even when I'm not logged in.~ Thanks to @laugardie, who has fixed the broken images. Please...

Replace S3 with MinIO in development environment

Update: will resume the work on this after getting the tests run without sensitive credentials.

Chore/rails 7 1 6

@EmCousin _a fixed it in #1994. We were using an outdated version of OpenResty.

Use external_id instead of id for admin routes

(was looking for a test task for some potential candidates. Noticed this issue is assigned to @binary-koan. Will look for another task)

Use external_id instead of id for admin routes

@nyomanjyotisa GitHub doesn't allow assigning this issue to you, probably because you need to be part of the GH organization? Either way, we can consider this issue is assigned to...

Link invoice line items to external sources, GitHub hover cards

Closing this in favor of #1507

Feat: Auto Apply Discount Code

@Pradumn27 could you look at the test failures?

Feat: Auto Apply Discount Code

Triggered CI, will continue reviewing on green build.