Mikel Larreategi comments

Results 169 comments of


                                            Mikel Larreategi

Fix race condition in rendering the toolbar in multilingual sites after saving a page

We have faced this too.

add a default noResultsComponents, and another for the imageGallery variation

@sneridagh can you look at this please?

add a default noResultsComponents, and another for the imageGallery variation

@sneridagh changelog and documentation changed. Thanks for looking at this!

add a default noResultsComponents, and another for the imageGallery variation

I think that's possible of course, let me check it with @ionlizarazu

add a default noResultsComponents, and another for the imageGallery variation

@ksuess and what about adding an option in the schema to hide the heading or the listing when there are no results? That's easier from the CMS user perspective: just...

add a default noResultsComponents, and another for the imageGallery variation

I see 😅

add a default noResultsComponents, and another for the imageGallery variation

@sneridagh then we can merge this one and then @ksuess' PR

add a default noResultsComponents, and another for the imageGallery variation

Thanks @stevepiercy for the review. I have reverted all those quotation changes. I really don't know why my editor does this kind of stuff... I am wondering if our .estlintrc...

Code analysis errors in newly generated addon and content_type template

Travis is already configured to run the code-analysis part already provided by buildout

theme_barceloneta: grunt setup broken

According to the folder structure, Gruntfile.js should be created on the package level and not in the 'theme' folder: https://github.com/plone/bobtemplates.plone/tree/master/bobtemplates/plone/theme_barceloneta I have made a quick test and I see that...