Mikel Larreategi comments

Results 169 comments of


                                            Mikel Larreategi

It's possible to set an invalid short name when adding content

I agree with Timo, I think we should do the same as Classic UI does. If we don't allow spaces in id in Classic we should neither allow that in...

Always return an effective_date value and fall back to creation_date if no effective_date is set.

I don't think Plone makes any assumption on effective date at the end it's the Catalog which sorts the search results, so if effective_date is not set and is None,...

[GSOC] User and Group Control panel

Please, see https://github.com/plone/volto/pull/4572

Plone views are interpreted as content, causing blank pages and crashing the Volto server

@JeffersonBledsoe that's why we have the [`nonContentRoutes` setting](https://github.com/plone/volto/blob/main/packages/volto/src/config/NonContentRoutes.jsx), right? AFAIK when visiting a route included there, Volto does not make the API call to the backend.

[Search Block] do not send sorting information by default

This is a search block which is not feature-paired with a Collection. When having a full text search you don't want to sort by effective date by default, it goes...

[Search Block] do not send sorting information by default

Well, I have no problem on adding the behavior that @davisagli suggests, but I think that's wrong. We already have a setting in the search block to let the user...

[Search Block] do not send sorting information by default

I have updated the PR with the SearchableText query test and rebased it on `main`

Site and navroot

I am aware that these changes are quite big and need further discussion, but I think it is worth to have them in Volto: - Build the tag using the...

Site and navroot

The tests are broken because they rely on the endpoints that are not available yet in the backend images

Site and navroot

I have reworked the PR following @sneridagh and @pnicolli's suggestions (use hasApiExpander helper and add conditionally the navroot content like it is done in the breadcrumbs reducer); added the `@site`...