Ernesto García

I made a prototype without using the `Ownable` contract and this is the result: ```solidity // SPDX-License-Identifier: MIT // OpenZeppelin Contracts (last updated v4.5.0) (access/AccessControlEnumerable.sol) pragma solidity ^0.8.0; import "./AccessControl.sol";...

I like the idea of removing `_transferAdmin` and keeping the `super.` in `_revoke`, however, `members` is not available in this context unless we save a boolean to represent that there's...

> I'm showked by how complexe _revokeRole and _grantRole are. IMO, these function should remain simple. > > Also, why do we introduce a new function transferAdmin ? > Either...

After a few attempts, this is the best I could come up with following overall comments: Code: ```solidity abstract contract AccessControlAdminRules is AccessControl { uint32 private immutable _delay; address public...

Partially solved in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3773, although there's no `toHexString` implementation

> What would the Hex representation of a negative integer be? I'd say there would be multiple Hex representations available, but that should be an standard so hold on for...

I completely agree with not supporting them all, but I don't know about any way of generalizing it, and there's no standard usage afaik > just hard-cast the int256 to...

Can you share a source (if any)? I haven't seen any two's complement on-chain, but maybe reaching out to people who's done it might be helpful

This thread is about EIP-1363 support and it's best to keep it that way. The [standard](https://eips.ethereum.org/EIPS/eip-1363) is already finalized so there's no way to make changes to it, even by...

> @ernestognw that comment about EOA, man you just can't prevent people from shooting their foot It's true we can't prevent people's mistakes, but we would prefer providing the simplest...