Ernesto García
Ernesto García
Doesn't seem to affect since we're using `undici` only to know whether we've already published a package in the release process, but there's no secret exposed to it or a...
There are a couple of updates. Retrying the CI.
There's a PR for this #4905, but the CI keeps failing when downloading the Solidity compiler. Haven't investigated deeply.
Catching up with this. I'd like to highlight that @Lohann started this looking for constant cost in math operations. Although it's not the kind of priorities OpenZeppelin Contracts has, it's...
> When you do a ternary choice, the compiler can "optimize" it so that only one branch is computer. However, when you use a dedicated function, values for both side...
Hey, thanks @rsolari for putting everything together, and also thanks @apbendi for sharing your input here. After reviewing ScopeLift's implementation, it seems to rely mostly on [GovernorCountingFractional](https://github.com/ScopeLift/flexible-voting/blob/master/src/GovernorCountingFractional.sol). In my opinion...
For the record, [this question came to the forum](https://forum.openzeppelin.com/t/erc20votes-liquidity-pools-and-dead-address/40098) asking for the effect of delegations when depositing to a liquidity pool.
After merging we'll most likely receive another PR to upgrade to the latest 6.x version. I'm updating in this PR.
Right, so we'll **have to** make this change before 9.x is released. Not sure when that's going to happen though but I'm adding the 5.x milestone so we tackle it...
I'd also be in favor of both unused imports and particularly custom errors these are later added to the `interfaceId` in some way