erm-g
erm-g
> Please address the failing tests. :) Fixed (few styling things)
> Hey, has anyone perhaps had a chance to look at this yet? Hi @wjohnst3 , we just merged a fix for unclear error propagation. It'll be included with the...
Closing since there is no response and we can't reproduce it without more info. Please reopen if needed.
Hi @Hodkinson, thank you for the reporting! So I see the same exception after executing `AdvancedTlsX509TrustManager.newBuilder().build(). updateTrustCredentialsFromFile(new File("I_don't_exist"), 1, TimeUnit.SECONDS, Executors.newSingleThreadScheduledExecutor());` What do you mean by >The updatedTime comes back...
> > Please add unit tests. > > There [appears to be a test for this already](https://github.com/grpc/grpc-java/blob/6e25c03a7bd43c089e3fd770b39e4d4b52347a28/netty/src/test/java/io/grpc/netty/AdvancedTlsTest.java#L452) but that test is a bit moot because it doesn't actually test much...
> @erm-g, are you okay with approving this and you'll make the test as a follow-up? Yeah, sure
> Please add unit tests. Test added in https://github.com/grpc/grpc-java/pull/11385
> API review meeting notes: > > > CERTIFICATE_ONLY_VERIFICATION and INSECURELY_SKIP_ALL_VERIFICATION > > Should document that these are dangerous to us, unless also specifying your own cert validation. Yes, one...
@ejona86 I applied the changes we discussed - PTAL