Erin
Erin
I have a feeling there's gonna be a fair amount of bikeshedding about naming conventions in this PR... I'm not a fan of naming conventions that mix `names-like-this` and `NamesLikeThis`....
Yeah I don't really think that naming convention applies super well to this project. For bigger codebases with lots more variability, it makes sense to have lots of options for...
> +1 for a single underscore to delineate names from ancillary data like CSS property or DOM state I'm kinda against this, to be honest. I'd rather our variables not...
Now that I'm looking at this again, there are security concerns with this solution. A malicious webpage could make a request to Reddit setting our cookie store header set and...
9d7e8a3 fixes the security concern by storing the `cookieStoreId` associated with a request in a metadata map rather than directly in a header; a randomly generated "request ID" is used...
The issue isn't CSS being applied twice like creesch mentioned in the Reddit post; the embedded document is not having the dark theme style applied at all, rather the iframe...
#914 moved modnotes window rendering into a portal to `document.body` so it's actually no longer being rendered in shadow DOM at all - need to fix this, probably with a...
Dependabot has been configured to give us 5.x updates for a while now, and we have a separate issue for upgrading to v6 #635. Closing this one in favor of...
I don't think there's anything left in this issue that needs addressing, so I'm closing it now. We can track moving to MV3 for Firefox in a separate issue, but...
Good call, thanks for flagging this