reddit-moderator-toolbox icon indicating copy to clipboard operation
reddit-moderator-toolbox copied to clipboard

Toolbox buttons aren't readable in RPAN chats

Open ParadoxMajor opened this issue 5 years ago • 3 comments

image

I used Stylus to fix the styling with this code, but it'd be nice if mods didn't have to override it that way.

body.mod-toolbox-rd .tb-general-button, body.mod-toolbox-rd li a.tb-general-button, body.mod-toolbox-rd .tb-bracket-button { background-color: transparent !important; color: rgba(255,255,255,.8) !important; border-left-width: 1px !important; }

If you need an RPAN sub to test on, let me know!

ParadoxMajor avatar May 24 '20 22:05 ParadoxMajor

Hmm... We should probably just reconsider having the button background be transparent. There's not really a good way to dynamically set text color based on the background the button is on, and I'd rather not hardcode an exception for this specific area.

eritbh avatar May 24 '20 22:05 eritbh

But whatever color you choose will be a problem in regular non-night mode vs. the night mode of RPAN chats (which is independent of your night mode setting)

ParadoxMajor avatar May 24 '20 23:05 ParadoxMajor

I think it'd be fine for the buttons to just always have a dark-text-on-light-background color scheme. It won't be the prettiest for dark themed areas, but we don't have any good way of knowing if our buttons are being put on light or dark areas of the page, so the best we can do is pick one thing that will at least be readable everywhere, even if it's not the prettiest.

eritbh avatar May 25 '20 17:05 eritbh

Given that RPAN was discontinued over a year ago, this is probably a closeable issue, as button transparency wasn't ever an issue anywhere else.

adhesivecheese avatar Feb 22 '24 23:02 adhesivecheese

Good call, thanks for flagging this

eritbh avatar Feb 23 '24 08:02 eritbh