Erin McNulty

icon indicating a website link https://erin2722.github.io/portfolio/ icon indicating an email [email protected]

icon company @mongodb icon location New York, NY icon location SWE @mongodb / Columbia University '23 / hackNY '20 / former head of engineering @spectatorpublishing

Results 3 issues of Erin McNulty

Fix team game logs for current season

This PR addresses #343 by applying the fix suggested in the issue, and adds in a test to verify that it is working.

Add support for custom date range searches in Fangraphs

This change addresses #293 by adding in `start_date` and `end_date` querying options to the Fangraphs functions. I didn't change any existing functionality in the Fangraphs function, but did make a...

DynamicTokenBucket::consumeWithBorrowNonBlocking will return incorrect value with very low rate

The following unit test demonstrates the issue: ``` TEST(TokenBucketTest, CanConsumeFirstTokenLowRate) { folly::DynamicTokenBucket tokenBucket; ASSERT_EQ(tokenBucket.consumeWithBorrowNonBlocking(1.0 /** toConsume*/, .0001 /** rate*/, 1.0 /** burstSize*/), 0.0); } ``` IIUC, this should succeed because...