erikn69

Results 113 comments of erikn69

@MarceauKa hi, this is PHPStan test, and PHPDOC fixes

> return $pdf= PDF::loadView('welcome', compact('data')); Why?? just `return $pdf= PDF::loadView('welcome', $data);`

>I'm also interested if we can define signature max length before signing Those optimizations would be better in a separate PR

> [merged pdfsignltv.php & pdfsigntsa.php](https://github.com/dealfonso/sapp/pull/70/commits/6b263ad113bf0c8fa97040db09fb801c9bc43355) I actually went to the trouble of separating it for a good reason. They can be used separately, That's why I created examples for each...

`?: "http://timestamp.digicert.com";` you removed the default value, but on the text shows `digicert` as default https://github.com/erikn69/sapp/commit/ac6ae194672601197027574dcea7ba0f6c24a642

The idea of ​​the example scripts is to show a specific functionality, not to add them as a group. For example, if I want to test TSA, it immediately adds...

>but how to bypass timestamping without removing that? any idea? That's why I created 2 separate scripts, but let's leave it like this, this does not affect the functionality

Hi, Could you try #3521 please, let your review

Fully working, but LTV is pending Also, the code is from https://github.com/dealfonso/sapp/issues/8#issuecomment-1059107230 and https://github.com/dealfonso/sapp/issues/8#issuecomment-1470039444, and there are probably shorter and better ways to do it, without needing to add [phpseclib](https://github.com/phpseclib/phpseclib)...