Erik Verbruggen

Results 43 comments of Erik Verbruggen

> Is addModalLegacyDialog still used anywhere, if not could you open a follow-up and remove it? The share dialog and the folder wizard still use it.

The problem is that we do a propfind for only the current level. So in the example above, "myfold" is initially not expanded. When it expands, we do a propfind,...

When he folder is expanded after pressing the arrow, and we find no children, the arrow should be removed. To do this, we have to emit a row/data changed signal...

The `SpacesManager` still needs to be hooked up. So maybe the `Utility` code needs to move to libsync.

See the screenshot in https://github.com/owncloud/client/issues/11533#issuecomment-2288816029

About tab contrast: For me (on mac) the contrast is fine. Which platform is this tested on?

For Windows most contrast issues are fixed by using the "High Contrast" theme.

With the "Aquatic" contrast theme on windows 11: ![Image](https://github.com/user-attachments/assets/67e05030-69b6-43e2-8427-8e1a8b6a8e87) ![Image](https://github.com/user-attachments/assets/03e98970-3b63-47b8-a93a-b8ea51d71258)

With the "Glow" (non-contrast) theme (Win11): ![Image](https://github.com/user-attachments/assets/c39e4ca8-0be8-4cd8-ba68-f2cce9ec6e1c) ![Image](https://github.com/user-attachments/assets/7d49bc33-6b64-4f89-9815-d23c0ee7873b)