client icon indicating copy to clipboard operation
client copied to clipboard

[QA] Folder without subfolder show the arrow icon

Open swoichha opened this issue 3 years ago • 1 comments

Seen with client 2.9.0-beta2 on Windows 10 (Enterprise Evaluation) version 21H1 (OS build 19043.1165)

  • Start to setup the oC Desktop app
  • Fill in server, user and password
  • In the new window select "Synchronize everything from server" and select/unselect different kinds of folder with and without sub-folder. Wait until everything is sync.

Actual

  • Click on a folder with and without sub-folder the arrows is displayed.
  • When minimizing the directory tree and opening the it again, the arrow for folder without sub-folder disappears.

Expected

  • Folder without sub-folder should not have arrows.

swoichha avatar Aug 24 '21 07:08 swoichha

Tested on ownCloud 6.0.0.13589-daily20240328 [32670a]

Expectation: arrow should disappear from empty folder :question:

Screenshot from 2024-03-28 15-08-01

@TheOneRing the expectation in this issue does not met. Will there be a fix to meet the expectation or arrow in the empty folders are expected (arrow will not disappear)?

saw-jan avatar Mar 28 '24 09:03 saw-jan

The problem is that we do a propfind for only the current level. So in the example above, "myfold" is initially not expanded. When it expands, we do a propfind, get back "empty" and "ufold", but we don't know if they have subfolders, so we show the indicator. We only know that "empty" is empty when it is expanded and the propfind returns 0 (zero) items.

I tried to do a propfind with depth 2, but that somehow fails: server replied: Bad Request.

erikjv avatar Aug 05 '24 14:08 erikjv

When he folder is expanded after pressing the arrow, and we find no children, the arrow should be removed. To do this, we have to emit a row/data changed signal and indicate that there are no children, which should make the arrow disappear.

erikjv avatar Sep 24 '24 12:09 erikjv