Erik Hide Sæternes
Erik Hide Sæternes
After looking at it quite a few times, I'm more or less certain that the indexing was wrong in the original implementation. And yes, the PID controller in OPM has...
I have tried to use only "pid" as input to `--time-step-control`, but so far I cannot say anything conclusive about what works best. My understanding is that the "target iteration...
> @erikhide, can you please rebase the branch on top of the master branch? Done!
This is meant to solve an independent problem in the adaptive time stepping. The pull request does in fact include the changes done in #4855, but the new changes related...
> Very good. Then I think we should maybe change the state of this PR to draft/work-in-progress pending #4855 so we don't inadvertently merge this in conflict with that work....
I don't know if I did it the correct way now, so please tell me if I need to fix anything.
@bska: I realised that I (by mistake) ended up including the commits from #4855 here. Hence, it should probably be merged after that one (and set to draft/work-in-progress pending #4855),...
> I think this should be addressed as well, but will not require it in this PR. @atgeirr: If you're right, then yes, that should probably be addressed. But the...
> > I realised that I (by mistake) ended up including the commits from #4855 here. Hence, it should probably be merged after that one (and set to draft/work-in-progress pending...
> Yes. Please rebase this onto the current master branch and then we'll start the review process. Done!