Erik Dubbelboer

Results 272 comments of Erik Dubbelboer

I agree that it would have been better if the `if statusCode == 0 {` wasn't in there. But I'm afraid we can't change this anymore without breaking backwards compatibility....

On the one hand it would be a backwards incompatible change, on the other hand I can see how this could cause bugs. Not checking the error before the statusCode...

If everything works fine then I will merge it.

> in case super strict deadlines not needed and you can fully rely on netpoller to stop connect call instead of interruptor goroutine Do you have any experience with the...

I'm afraid I currently don't do anything with http2. I see you have continued working on your implementation. How is that going?

I think if you implement http2 in the fasthttp repo instead of a separate one it makes the most sense to have it be one big pull request/commit. So working...

Creating and start using the new client will always slow things down. The new client will have to setup new connections and do TLS handshakes which is slow. And with...

I would change the 100 to 7 in my example. Then each 15 seconds all requests will switch to a new client. 7 seconds from `clients` and another 7 seconds...

It needs to be `newClientCreatedAt[proxy]`. Are you sure it's an empty response with a 200 status? Sounds like an issue on the server, maybe it can't handle that many requests...

Yes but I'm also sure they have some form of spam protection when a lot of requests are coming from the same IP. They are too big a target not...