Erik Dubbelboer

Results 272 comments of Erik Dubbelboer

What if you have multiple goroutines calling `wg.Wait()`? I can't imagine WaitGroup has any bugs in it.

Is there so much code that an `internal` package is really needed? I was hoping it would all fit into something like `fs_embed.go` in the root.

Hard to judge without diving deep into it. Isn't it possible to add an `embed.FS` to `fasthttp.FS` and use that to list dirs and open files if provided. For caching...

This is indeed a bug, a pull request would be welcome. I think it's as easy as ```go if reqConf.MaxRequestBodySize > 0 { maxRequestBodySize = reqConf.MaxRequestBodySize } else if s.MaxRequestBodySize...

What is the reason you want to add this method? Why can't users of fasthttp just do `string(a.Peek(key))` themselves?

But there are no other methods that return strings. Everything returns bytes to prevent allocations. If this is too difficult for someone they **really shouldn't be using fasthttp**.

Is this the same issue as https://github.com/valyala/fasthttp/issues/775 and https://github.com/valyala/fasthttp/issues/940?

> @erikdubbelboer what is status of HTTP2 support in FastHTTP? HTTP2 will probably never be supported by fasthttp. To be honest I would just switch to `net/http` as soon as...

@antirez is there a place to track the implementation of cluster support for modules? I would also be interested in this for https://github.com/erikdubbelboer/discnt