erikdesjardins

Add #[inline] to Option::copied/cloned

6

In https://github.com/rust-lang/rust/pull/121665#issuecomment-1987102294, I noticed that `Option::cloned` stopped being inlined in some backtrace code. Let's see if this helps. r? @ghost

Stop using LLVM struct types for byval/sret

33

For `byval` and `sret`, the type has no semantic meaning, only the size matters\*†. Using `[N x i8]` is a more direct way to specify that we want `N` bytes,...

Stop using LLVM struct types for array/pointer offset GEPs

10

...and just use a byte array with the same size as the element type instead. This avoids depending on LLVM's struct layout to determine the size of the array/pointer element....

Copy byval argument to alloca if alignment is insufficient

3

Fixes #122211 "Ignore whitespace" recommended.

byval argument of C ABI function passed to Rust ABI function has insufficient alignment

2

I tried this code: ```rust #[repr(align(16))] pub struct HighAlign { x: u128, y: u128, } extern { fn consume(x: &HighAlign); } #[no_mangle] pub unsafe extern "C" fn takes_aligned(x: HighAlign) {...

Represent `Result<usize, Box<T>>` as ScalarPair(i64, ptr)

24

This allows types like `Result` (and integers of differing sign, e.g. `Result`) to be passed in a pair of registers instead of through memory, like `Result` or `Result` are today....

Provide a proper fenv implementation

2

See https://github.com/japaric/libm/pull/106#issuecomment-405051281 [src/math/fenv.rs](https://github.com/japaric/libm/blob/master/src/math/fenv.rs) currently contains a dummy implementation of `feraiseexcept`, `fegetround` and friends. It should be properly implemented.

Shows up here: https://noembed.com/embed?url=http%3A%2F%2Fxkcd.com%2F859%2F The HTML produced (after parsing the JSON) is: ``` html

Initialize struct with the correct number of members

4

b5ade1a697b48c7893fbbbde3d708ed9bb111f29 (#78) added two members to this struct, but only one to this initializer. This leads to undefined behaviour when rendering something like `#/u/test`, since the other callback functions are...