Mark S. Miller comments

Results 574 comments of


                                            Mark S. Miller

SES error censorship issues

An relevant irony buried in https://github.com/endojs/endo/blob/f8aa142fb0fd70c366296e168097ff4d819db1e5/packages/ses/src/error/tame-console.js#L149-L165 is that (in this browser case) `errorTrapping: 'none'` doesn't mean *none*, it means *use the platform's default trapping behavior*, whereas `errorTrapping: 'platform'` doesn't mean...

Type errors for freeze(causalConsole);

I did not understand this. "LSP"?

Where the Node console gets confused if `constructor` is an accessor

See #944

Where the Node console gets confused if `constructor` is an accessor

See https://github.com/endojs/endo/issues/2908

Where the Node console gets confused if `constructor` is an accessor

The snippet above has grown into the code at https://github.com/nodejs/node/blob/fc3f19ef932444e8de5d69fe3fb5033b2e0ec2e4/lib/internal/util/inspect.js#L627 If the prototypes whose constructors we make into accessors were added to `wellKnownPrototypes`, our problems my well disappear.

test(ses): repro 2941 errorTrapping bugs

PTAL

docs(marshal): expand smallcaps readability invariants

@kriskowal , I only changed one *.md file and all my CI tests are red. And again on retry. Help!

docs(marshal): expand smallcaps readability invariants

> @kriskowal , I only changed one *.md file and all my CI tests are red. And again on retry. Help! Seems healed. Nevermind.

docs(marshal): expand smallcaps readability invariants

PTAL, thanks.

fix(ses): fix 2943 error trapping issues

This is now Ready for Review