endo icon indicating copy to clipboard operation
endo copied to clipboard

Type errors for freeze(causalConsole);

Open kriskowal opened this issue 4 years ago • 2 comments

I’m locally seeing LSP hints that freeze(causalConsole) in two places within ses/src/error/console.js due to a combination of freeze (unlike harden) translates all the properties into readonly versions, and the runtime uncertainty about this code generating all the properties of VirtualConsole. We could either cast here, or cast freeze to a pass-through identity function type, or some combination.

kriskowal avatar Jul 15 '21 02:07 kriskowal

I did not understand this. "LSP"?

erights avatar Jul 15 '21 06:07 erights

Language Server Protocol. It’s the thing that lights up lint errors in VS Code, and I have a Vim plugin that uses it. TSC isn’t complaining about it in CI because the file doesn’t have // @ts-check, but that doesn’t prevent IDE’s from noticing.

kriskowal avatar Jul 15 '21 06:07 kriskowal