Eric Waldheim

Results 12 comments of Eric Waldheim

The use case is a custom-protocol server with clients (that we do not write) that close the socket at any point in any way. I call .destroy() only from test...

strong-oracle runs on 0.12. This one appears to be done.

(I doubt that will happen but FYI I long ago submitted a pull request to get it running with nan https://github.com/joeferner/node-oracle/pull/223)

Yes, that's how it works. It works the same way in sqlplus. This issue can be closed. (You could write a wrapper around it to do the grunt work for...

https://github.com/strongloop/strong-oracle

And it is indeed more appropriate for a separate wrapper module.

FYI: https://github.com/joeferner/node-oracle/issues/246#issuecomment-70934114

I looked into the Clear() issue further. Looks like the converted code with Clear removed is correct. Here's the translation in nan: https://github.com/rvagg/nan/blob/d945fd11f83c6ba612c3eefcd579edaab5aa2e2e/nan.h#L1573-L1578 ``` javascript template NAN_INLINE void NanDisposePersistent( v8::Persistent...

Here is the relevant comment from nan docs for "issue 1)" mentioned above. I believe this is converted correctly. https://github.com/rvagg/nan#localstring-nansymbolconst-char-

I have added this feature to my copy of node-oracle. I added a config object parameter (as optional 3rd parameter) to the Connection::Execute function. So the call looks like: ```...