Alex Vlasov

Results 32 comments of Alex Vlasov

As @jrhea [pointed out](https://github.com/ethereum/eth2.0-specs/commit/04fb9926e819535d32d5c22ed8616c4a0b8a25e9) it's dropped by intention. So, it looks like `is_valid_fraud_proof` has not been updated appropriately

It might be helpful to use [Nagini](https://github.com/marcoeilers/nagini) to specify pre- and post-conditions (as well as other useful annotations). It enriches statically-typed Python3 subset ([PEP-484](https://www.python.org/dev/peps/pep-0484/), `mypy`) with constructs to specify pre-conditions...

Loading from initial state implemented in #182 (merged into develop too). Loading from finalized state is not implemented yet.

The test scenario files are generated by augmenting our current Kotlin fork choice tests, the code is not part of a public repo yet. I'm currently splitting the tests into...

I've pushed test executor and other test updates. [https://github.com/harmony-dev/beacon-chain-java/tree/tests/fork-choice-integration-tests/qa/src/test/kotlin/qa](https://github.com/harmony-dev/beacon-chain-java/tree/tests/fork-choice-integration-tests/qa/src/test/kotlin/qa) There are two Kotlin files with tests, one for [block](https://github.com/harmony-dev/beacon-chain-java/blob/tests/fork-choice-integration-tests/qa/src/test/kotlin/qa/integration_tests/on_block_tests.kt) tests and another one for [attestations](https://github.com/harmony-dev/beacon-chain-java/blob/tests/fork-choice-integration-tests/qa/src/test/kotlin/qa/integration_tests/on_attestation_tests.kt). They can be run using...

New test scenarios attached [fork_choice_integration_tests.zip](https://github.com/ethereum/eth2.0-spec-tests/files/4000404/fork_choice_integration_tests.zip)

I've finally adapted fork choice tests so that their format is aligned with the existing eth2.0-spec-tests. Tests are for v0.10.1 tag - I have validated them with Teku, which currently...

@protolambda Thanks for the comments! I do want to put more time. I want to develop or generate more tests to improve coverage and disk space. Most tests do not...

@protolambda I've converted tests to a new format and put in a [new branch](https://github.com/harmony-dev/eth2.0-spec-tests/tree/fork_choice_integration_tests_v2/tests/minimal/phase0/fork_choice/integration_tests). Two main ideas: - one file with test description per each test case. So a suite...

I record events during a test run, and when converting the trace to a file, I'm using a de-dup cache. It's not an external procedure currently.