Eric Gentry

Results 51 comments of Eric Gentry

Tab name has been shortened to "Align" with the just released v1.0, this has been resolved! Happy aligning :)

@krassowski Pinging you in case you haven't already seen the approval here.

@jtpio The last example (the provider-consumer pattern demo) is nearly complete (minus a trivial addition of an update signal for the step count and some minor renaming) if you want...

@jtpio If you have time to review I'd like to get this approved, then merge the extension PRs FIRST before this one. Thanks :)

I split off the plugin_system and provider/consumer pattern document into a new PR: - https://github.com/jupyterlab/jupyterlab/pull/15417

Thanks @fcollonval for the improvements, updates and formatting. I have some feedback for a few pieces: I think if our goal is to include chemists, physicists, other technical non-programmers, and...

> > think if our goal is to include chemists, physicists, other technical non-programmers > > ... > > "Dependency Injection Pattern" is actively harmful to that goal. Using "Provider-Consumer...

I pushed some edits/refactors as discussed above, and verified that the code snippets are up to date with the current version of the examples repo. Waiting for CI now.

I changed the title, and made [another PR](https://github.com/jupyterlab/jupyterlab/pull/15866) for some of the extra suggestions. Waiting for CI build to review.

> There is a failure in the docs test, could you take a look? > > ![image](https://private-user-images.githubusercontent.com/5832902/307887188-fefdfdae-80be-456a-a148-23c011532c58.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg5NzgxOTgsIm5iZiI6MTcwODk3Nzg5OCwicGF0aCI6Ii81ODMyOTAyLzMwNzg4NzE4OC1mZWZkZmRhZS04MGJlLTQ1NmEtYTE0OC0yM2MwMTE1MzJjNTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDIyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAyMjZUMjAwNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzEzZjFjMzYyMjQyMGM2ZmU2N2ZlM2QwZmNmMmZiNjViNWYzOWJjNDU0NWQxMmZjOWQ1ZjVkZDU1ZDBiODE2OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Nc8JPlxJOKhOkgqv1IeuubqxTj7MIQU3C3tJNAYe4IA) Resolved 👍