Eric Pien

Results 6 comments of Eric Pien

hey @ValueRaider I noticed this was converted to draft. Should I still review as is? I see the vision in 1. Splitting out Ticker to underlying functions and 2. Changing...

@bala-v, did this code ever work before? 1. yahoo ticker for s&p 500 is `^GSPC` 2. `Tickers` works by passing through a list / string of tickers, not index name....

I ran into this too. I think the first `test_price_repair.TestPriceRepair.test_repair_bad_div_adjusts` and `test_price_repair.TestPriceRepair.test_repair_zeroes_daily` are related to https://github.com/ranaroussi/yfinance/commit/8daa47716766cca2820b9bf78bb9f4487d387c7c as when I checkout the branch before that, it doesn't report the errors. As...

1. what do you mean the "types are wrong"? 2. What does it mean to "determine the types of the Screener class"? 3. How can we improve the documentation for...

Below are just my two cents: I think this affects more than just `types` as initially proposed and there isn't much example/test code to infer. Can you edit the tests...

I was able to reproduce by testing on Python 3.11, while it was not reproducible in my dev environment (Mac + Python 3.12). It must be related to https://docs.python.org/3/whatsnew/3.12.html#pep-701-syntactic-formalization-of-f-strings in...