Eric Hanson
Eric Hanson
IIRC Registrator hasn't been in the business of compat bounds, but rather RegistryCI. Moreover, I would prefer checks like this to go to the latter bc RegistryCI itself has CI...
Taking another look at this: 1. Guideline: https://github.com/JuliaRegistries/RegistryCI.jl/blob/0c50828db74921c7cd34b18da47ac0ddf9376a39/src/AutoMerge/guidelines.jl#L91 2. Utils function: https://github.com/JuliaRegistries/RegistryCI.jl/blob/5f0aba4f6b95bfb63f03ab803f39721c2cd55baf/src/AutoMerge/util.jl#L232-L244 3. General's workflow: https://github.com/JuliaRegistries/General/blob/a71c6fbf0766c12f54ea1cf23a3e7dc7277f380a/.github/workflows/automerge.yml#L22 It looks like once 1.9 is out, General's AutoMerge workflow will switch to 1.9,...
@giordano can probably comment on that! I think it was 8 minutes if you have a bunch of cores and good network access.
Oh right, 8 minutes was without the history. > So I think for check 2, it will probably be easier to just clone the repo being registered and only run...
True, though we only run automerge on registrator PRs currently and registrator gets its version from the source’s Project.toml, so there’d have to be a registrator bug for this to...
I think this is often OK; for example, you can use compat to restrict the versions of test-only dependencies, which can be important for tests to pass! And a package...
I think we should do all 3 of: * `src` must have at least X lines of Julia code * `test` has a runtests.jl file and at least Y lines...
In terms of implementation, I already started preparing for this when implementing the license check. In particular, during the AutoMerge process, we place a copy of the source code here:...
> The various thresholds are specified by environment variables to make them easy to control from the registration workflow. Does that seem reasonable? So far we've mostly handled this via...
Those names look reasonable to me