RegistryCI.jl icon indicating copy to clipboard operation
RegistryCI.jl copied to clipboard

Version number consistency

Open GunnarFarneback opened this issue 3 years ago • 3 comments

Nothing good will come if the registered version number does not match the version number in Project.toml in the given treehash. That these are consistent should be verified and should be easy to do as part of the "code can be loaded" check.

GunnarFarneback avatar Sep 13 '21 09:09 GunnarFarneback

True, though we only run automerge on registrator PRs currently and registrator gets its version from the source’s Project.toml, so there’d have to be a registrator bug for this to hit General at this time. So at least it can’t just be user-error. Agreed it’s a good check to have though.

ericphanson avatar Sep 13 '21 09:09 ericphanson

I think it's fine to add the check even if we assume that Registrator always do it correctly. We have some other checks (e.g. the list of files modified in a PR) that similarly should never fail on Registrator PR, but we still check it just as a internal consistency check.

DilumAluthge avatar Sep 13 '21 19:09 DilumAluthge

In addition to possibly catching Registrator bugs this is a useful consistency check for people who run RegistryCI on their own registries, which may get PRs from other sources.

GunnarFarneback avatar Sep 13 '21 21:09 GunnarFarneback