ericokuma
ericokuma
Looks great! I would just capitalize the connector and we are good to go with this ticket!
@jkhwu, FYI. Some initial notes: - [x] Match the height of the dialog in the mock. The height shouldn’t change based on the tab selection - [x] The form field...
I'm not able to get the entire functionality in v0 to be 100% detailed and correct. That being said, what you have looks good with the exception that the default...
okay, sounds good!
lgtm! I'm guessing the contextual help tooltips are coming later?
@lovincyrus, i'm guessing these will go into [APP-166](https://linear.app/rilldata/issue/APP-166/refine-add-data-form-components)?
Just reviewed with @mike that we can probably remove the `managed` checkbox from the Clickhouse form @begelundmuller, any objection to this?
Some feedback on the ClickHouse updates: - [x] Have self-managed ClickHouse be the first option in the dropdown vs Rill-managed - [x] When self-managed ClickHouse is selected, display the following...
@begelundmuller, how crucial is the `Cluster` config? Do we need to ever display it?
lgtm! Only feedback is that username and password shouldn't be marked as **optional**