Clickhouse human readable error message and design improvement
Closes https://linear.app/rilldata/issue/APP-88/improve-connector-form-errors and https://linear.app/rilldata/issue/APP-87/improve-error-handling-in-rd-for-connector
Reference from https://www.notion.so/rilldata/Improve-Connector-form-errors-1f2ba33c8f5780db892cf59cea5f9726
This pull request improves the ClickHouse error messages reported by users. We've updated the testOLAPConnector to receive the connector name rather than the new connector name. This ensures that when we test the connection. We're testing against the exact connector name rather than the incremented names. In addition to adding human readable error message handling for ClickHouse, we've also modified the SubmissionError component according to the design.
Reviewers - If you are aware of any clickhouse error message, let me know!
Checklist:
- [ ] Covered by tests
- [x] Ran it and it works as intended
- [x] Reviewed the diff before requesting a review
- [ ] Checked for unhandled edge cases
- [x] Linked the issues it closes
- [ ] Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
- [ ] Intend to cherry-pick into the release branch
- [x] I'm proud of this work!
This is what I currently see in your PR:
This is the design:
alert-dialog_BYO-OLAP - RILL Developer (Figma)
Also, looks like it's repeating the error message as opposed to the generic:
"Connection failed
We got the following error when trying to connect to {connector_name}. Please check your connection details and user permissions, then try again".
Lastly, in the PR, the error message is currently labeled Details . Let's use the phrase `Connection error"
Latest:
https://github.com/user-attachments/assets/f35399b2-5eae-40ea-9632-6cc75c91ea83
Looks great! I would just capitalize the connector and we are good to go with this ticket!