Eric Nordelo

Make the Account setPublicKey function a two-steps process

4

https://github.com/OpenZeppelin/cairo-contracts/blob/b764660da224ee757b831ea62bf7a4c63ee898fb/src/openzeppelin/account/presets/Account.cairo#L47-L53 This method can make the contract unusable if a wrong public key is set by mistake. Maybe it would be good to add a two steps process allowing to...

Define (or select) and follow a code format for cairo contracts

1

Document this code format practices in the repository.

DOC: Add cairo-nile dependency to setup.cfg

1

Nile is a requirement for the **Development** section, but is not installed with `pip install .` (the dependency is not set in setup.cfg).

Generate a text report for Terminal with Colors (show command)

5

I think it would be helpful to have a reporter for Terminal, showing colors depending on the coverage percentage for each covered file.

Fixes #409 #### PR Checklist - [x] Tests - [x] Documentation - [x] Added entry to CHANGELOG.md - [ ] Tried the feature on a public network

Fixes #939 #### PR Checklist - [x] Tests - [x] Documentation - [x] Added entry to CHANGELOG.md - [ ] Tried the feature on a public network

Document ERC721ReceiverComponent

1

Fixes #913 This PR adds the missing documentation for the ERC721ReceiverComponent, and also fixes the name of the mixin implementation. #### PR Checklist - [x] Tests - [x] Documentation -...

This issue aims to reduce the examples' code size by consistently using mixins instead of separate embeddable implementations.

`pop_log` and `assert_indexed_keys` code were updated, and `deploy_with_salt` was added. These changes are not reflected in the documentation.

Currently, we are expecting `(r, s, y)` as the signature being `y` the parity, when `(r, s)` is enough for verification purposes.