Eric Nordelo
Eric Nordelo
Always scope IDs by the module name in API Reference. Under the `ERC20` module section, the `name()` function should have the ID: `ERC20-name`
Words in html IDs (adoc pages) must be separated by dashes: `ERC20-name` instead of `ERC20::name`
> what do you mean by scope IDs? is this an ascii doc thing? The ID of the HTML section generated from the adoc file, should be scoped by the...
Put `SRC5 ID` block as a section (similar to Functions and Events) on top at the Interfaces where the ID is usually exposed.
> Do we? I'm assuming there will be no projects using Cairo0 (`c0` for short) and `c1` simultaneously. If so, nile 0.13 should be enough for `c0` projects, no? Right....
The hint could be executing this from console (from starknet cli): ``` starknet tx_status --hash TRANSACTION_HASH --network=NETWORK ```
I left the proposed specification in the linked PR.
The format defined in Starknet: https://github.com/starkware-libs/cairo-lang/blob/de741b92657f245a50caab99cfaef093152fd8be/src/starkware/cairo/common/uint256.cairo#L9-L14
Regarding scoping: - The `[external]` annotation is used to make a method a public entry point as defined in the protocol. - We use the `#[internal]` annotation for functions that...
Proposed rules for grouping imports: - Group only children (avoid `use mod_a::{mod_b::mod_c, mod_d}`) - Group by logic units (related) avoiding more than three lines per group. Ex: Instead of this:...