Eric Nordelo

Results 33 comments of Eric Nordelo

@Amxx I'm using your Governance implementation, and I want to check proposal deadlines with Timestamps instead of Block Numbers. Currently, you have a hardcoded Timer.BlockNumber in the ProposalCore struct inside...

Got it, makes total sense, just would be nice to get this Idea of Generic as soon as possible because now the workaround that we have is copying the Governor...

The PR to be reviewed: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3080

This version of the Account.cairo preset allows estimating fees or simulating transactions from starknet cli (or nile wrapping the latter), by accepting the transaction version for queries (2**128 + TRANSACTION_VERSION).

> Looking good, @ericnordelo! I left a couple questions and one tiny suggestion. Also, do you think we should document the tx query feature in the Accounts docs? I don't...

Could be related to #465

In README.md it instructs to compile the contracts using Nile after executing `python -m pip install .`. But this won't work if you haven't installed Nile previously (because it is...

I don't get it, let me know what I'm missing: This Proxy.initializer is meant to be called from the code of the implementation right? And the implementation is declared (but...

Now makes sense. I wasn't considering that a contract could extend from different libraries simultaneously (of course). With this said: > And users (if following the extensibility pattern) shouldn't call...

- Don't include argument types in the header sections for `Utilities`, `Functions`, and `Events`, in the API Reference.