Eric Newton

Results 145 comments of Eric Newton

So, are you cool with restructuring the files a little? ``` $ cp ./jquery.colorbox.js ./dist/jquery.colorbox.js $ uglify-js ./dist/jquery.colorbox.js $ uglify-js ./i18n/*.js ./dist/i18n/*.js $ mv the core css classes from exampleN/colorbox.css...

+1 from me. jquery loaded via AMD so theres no global jquery, and colorbox doesnt register. Probably need a pullrequest. For the time being will have to add a UMD...

You're probably gonna need to adjust those values once you need them. That's more of a data translation task.

Nice. A placeholder for moving to roslyn, just so I can add a +1 :)

Fair enough. Thanks for the quick response. I might hit you up for collab status and start merging pull requests possibly.

I'm running into a scoping problem too. Using this with angular 1.4.9 atm

Sounds good. I believe just have to create a type that implements ILocation so it can be fed into request.Address property.

@richardthombs was looking for a review and comments of this. This is a change to the public API to better support dependency injection and to fix a couple of issues...

That part wasnt really the DI part, that was just establishing a base class for all the services that unified the interfaces a bit. Although it started to break down...