Eric Ma

Results 429 comments of Eric Ma

@anzelpwj no problem! Can you do a thing - can you get a PR with some starter commits going, and then allow maintainers to commit to your PR directly? In...

Thanks for bringing this up, @szuckerman! There's definitely inconsistent behaviour w.r.t. copying a dataframe or not inside each function. This is something I think should be fixed at the SciPy...

@szuckerman I just realized I let this ball drop. We now have a data dictionary thingy, and I think you could add another custom accessor that allows for validation of...

@zbarry I'm glad you brought this up, this has also been on my mind for a while. I'm in favour of standardizing, but like the `inplace=True/False` issue, it means we...

> I look at pyjanitor as being more like a SQL query. It's run at the beginning of an analysis and then one interactively performs EDA or other statistics on...

@hectormz thanks for raising this! It's an important point. Perhaps there should be a dependency guarantee guideline (hesitant to make it "policy" before knowing how this will play out). Something...

Indeed! I'd be happy to accept individual PRs per example, with new issues are raised per example to keep track of progress.

Thanks @SorenFrohlich! Looking forward to your PRs :smile:.

@samukweku we would love to see a contribution from you! Examples are usually the hardest for maintainers to write, so I’d love to see what you’ve got! Going forward, let’s...

Hi @samukweku, thanks for being so thorough with the checks! This seems to be a sphinx error, but there's a lack of detail in the trace that Sphinx has provided....