Eric Ma

Results 429 comments of Eric Ma

This makes sense to me! Let's go with the plan. :smile:

@zjpoh on request from a colleague, I'm going to release 0.18.2 soon (nothing seems to be backwards-incompatible, so it's just a patch release). I'm going to rename this issue to...

@szuckerman for versioning, this is a great idea! I have been extremely sloppy in this regard. I think the proposal that you have for versioning is reasonable, so let's go...

@zbarry sure, I guess it's a matter of writing good dev docs. Would you like to take a stab at writing that section? We could collaboratively edit it in a...

Let me go in and protect the master branch.

Guys, done. New default branch for new PRs is dev. Also protected `master` such that it requires an explicit PR. @szuckerman and @zbarry thanks for taking the initiative on this....

Hello @GuiMarthe! Thanks for chiming in. Yes, there are a lot of dependencies for pyjanitor. I think the dependency sprawl has been something I haven't managed well in the past,...

> Also, should we add messages and/or warnings whenever the user tries to use a method that depends on a non-installed dependency? @GuiMarthe yesss! That sounds like a great idea....

Actually, that sounds like a good idea, @hectormz! @GuiMarthe, can I check in, do you have bandwidth to handle this one? I ran into a bit of a busy patch...

As long as the docstrings are truly minimal examples, then they should be reasonably copy/paste-able into a Python interpreter session. We can use that output in the docstring, I think.