Eric Chiang

Results 140 comments of Eric Chiang

Thanks! I'm on vacation this week, so will look at this more after the holiday. One note is that because this PR changes an exported signature, we'll have to create...

I've gone ahead and started a v2 branch https://github.com/go-piv/piv-go/releases/tag/v2.0.0-alpha.2 Still confirming that it works with Go modules, but feel free to target that branch

I haven't worked on dex in a long time, so you may want to reach out to one of the existing maintainers for review: https://github.com/dexidp/dex/blob/master/MAINTAINERS

Thanks Damien, Looking into the implementation, Equal is powered by [protoreflect.Value.Equal][val-eq]. Would it be okay in principle to add a Compare method to that type as well and switch Equal...

I went ahead and sent https://go-review.googlesource.com/c/protobuf/+/686795

I inherited a system a while back that depended on the determinism of the old marshalling, defiantly not something that I want to encourage...

Gah github, I accidentally closed this ~and don't have permissions to reopen...~ (edit nvm, apparently I do) I inherited a system a while back that depended on the determinism of...

@rouxcorp not being prioritized on our end but would be happy if someone wants to send a PR. We'll probably be avoiding a "special claim" though. Just a cookie that...

@burdiyan I think this feature quest is just cooking an end user, so when they come back to dex they don't have to login again and are immediately redirected with...

> dex uses that id_token_hint to figure out which connector to use, forwards the browser to, say /auth/okta (let's assume SAML) I really like this approach.