Eric Chiang

Results 121 comments of Eric Chiang
trafficstars

Thanks for the note! So you're saying that adding that CA to the function here didn't work? Do you get the same error? https://github.com/go-piv/piv-go/blob/0383b0aa884b2b642e9e3446ea01ba22ccadc83a/v2/piv/key.go#L347 I have a 5.7.1 and attestation...

Would it be possible to try https://github.com/go-piv/piv-go/pull/176 ?

Would you be able to provide the certificate that's not validating? Without that, it's hard to debug what's happening

Perfect! I went ahead and merged that one. Will cut a release when I get a sec

Tagged https://github.com/go-piv/piv-go/releases/tag/v2.4.0

Probably time to finally do https://github.com/go-piv/piv-go/pull/108 ?

Is there a specific provider your dealing with? Are you using HTTP/2 or another protocol? Is that during `io.ReadAll` or somewhere else? I believe `req.Close` is used to disable keep...

> @logicfox, I agree that it would be really convenient to be able to define clients with CRDs, but this doesn't currently work -- as the documentation states, "Admins should...

This should be fixed on the v2 branch, but I want to make sure there's some agreement that we don't need to change any other APIs before tagging (#153). Is...

The v2 version now supports different management keys. Switching to that should be sufficient?