Eric Agol
Eric Agol
@rodluger Will campaign 14 EVEREST 2.09 light curves be available soon? (Asking for a collaborator). -Eric
For specifying the initial parameters of the system, we need to specify the masses and the initial coordinates. For the initial conditions, the masses are specified before the orbital elements....
The `g!` function takes the dot product between the sky velocity and position of two bodies relative to one another, and this is monitored to see when the sign changes...
I think that the state needs to be reset if a transit is found before a transit is checked to have occurred for the next body. I think at the...
I think that this `ri` variable was meant to be the sky-projected separation to see whether the transit was happening close enough on the sky to approach the stellar radius:...
Perhaps we could try the approach used in this paper: https://arxiv.org/abs/2105.11671
There may be an error in the code in which the 4th-order correction is not included due to bodies which are in A or A^C: https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L69-L114 https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L116-L169
I think these lines of code may need updating: https://github.com/ericagol/NbodyGradient.jl/blob/9a0ecc99647eaa91e58068ece6f3c30c999d318f/src/outputs/Outputs.jl#L28-L33 to match https://github.com/ericagol/NbodyGradient.jl/blob/9a0ecc99647eaa91e58068ece6f3c30c999d318f/src/transits/Transits.jl#L102-L104
Sometimes ekepler can have a huge number of iterations - this needs to be limited.
https://github.com/ericagol/NbodyGradient.jl/blob/0afa7a5fd387b307e3704ded05ec01838b01478c/src/integrator/ahl21/ahl21.jl#L1139-L1140 We can combine three of the terms into a single term squared: `-\beta(\eta_0G_2+r_0G_1)^2`