NbodyGradient.jl icon indicating copy to clipboard operation
NbodyGradient.jl copied to clipboard

Published 20 hours ago • verified publisher icon ericagol

Correction term with fast kicks

Open ericagol opened this issue 3 years ago • 4 comments

There may be an error in the code in which the 4th-order correction is not included due to bodies which are in A or A^C:

https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L69-L114

https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L116-L169

ericagol avatar May 25 '21 20:05 ericagol

These functions are correct. However, David Hernandez found an error in the ahl21 routine by which the drift and kickfast calls were swapped.

ericagol avatar May 27 '21 03:05 ericagol

Was this fixed? @ericagol

langfzac avatar May 17 '22 18:05 langfzac

Yes, it was.

ericagol avatar May 17 '22 19:05 ericagol

It might be worth tracking down which pull request fixed this before closing the issue.

ericagol avatar May 17 '22 19:05 ericagol