Erez Shinan

Results 357 comments of Erez Shinan

Hi @Xowap , The reason you're getting one letter each time, is that you're using a non-greedy regexp in TEXT (`+?`) which means it only matches one character. You should...

As you say, "import" is TEXT, but TEXT doesn't stop at whitespace, it is greedy and matches to the end of the line. If you want "import" to mean something,...

Then maybe you should make TEXT scan until it reaches `__`. You can use regex lookahead syntax for that.

I was thinking we'll just add a new param, `type_=None`, and change `inst.type = type` to `inst.type = type_ if type_ is not None else type` The downside is we'll...

Why did you write ```python def __new__(cls, *args, **kwargs): if "type_" in kwargs: return cls._deprecated_new(*args, **kwargs) return cls._future_new(*args, **kwargs) ``` Instead of just - ? ```python def __new__(cls, *args, **kwargs):...

> errors will be more readable: That's a bit of a nitpick. I can easily add this, and get an even better error - ```python def __new__(cls, *args, **kwargs): if...

Thanks! I see, you're right, the behavior changes for imported modules. I'll look into adding it.

@marcinplatek Thank you for your contribution! Sorry it took so long to review and merge,

I don't think it should be too hard to change `type_` to `type`, as long as we add an optional `type_` parameter, that overrides `type` when given. I'm not very...