Rafael Fernández López

I have created a PR for webpki (https://github.com/briansmith/webpki/pull/260) that addresses this issue. I will open the PR for adapting `rustls` if the proposed `webpki` PR happens to be accepted and...

As a consumer, [an example on rustls prior to this PR we have](https://github.com/rustls/rustls/blob/a96c93c16d6578f6302318050bf13eb39345fd3f/rustls/src/verify.rs#L325-L327): ```rust fn verify_server_cert(...) -> Result { ... cert.verify_is_valid_for_dns_name(dns_name.0.as_ref()) .map_err(pki_error) .map(|_| ServerCertVerified::assertion()) } ``` With this change, this...

> I need this right now Please, let's keep the discussion on this PR to the point. Brian has already done a lot of work pointing to some hints on...

> I think a useful addition to this PR would be std-feature-gated construction of IpAddress from std::net::IpAddr. Perhaps a From trait implementation. @ctz: Just updated the PR with the conversion...

> Hey guys, so what's blocking the merge of this PR? From my side this is ready to go.

@djc Thank you, I will keep that fork up to date if I happen to add changes here. I am going to cherry pick the commits back to this PR...

> I will do that tomorrow. Well, not quite. Updated now and synced with https://github.com/rustls/webpki/compare/main...rustls:webpki:feat-ip-address

@djc I can do that without any issue, but I see that https://github.com/rustls/webpki/pull/5 is already open. I synced this PR with that. Do you want me to still open a...

@lucacasonato It has the IP address as a SAN at the end too, so with https://github.com/briansmith/webpki/pull/260 it should work.

> Yes, but it errors as soon as it reaches the invalid DNS SAN record. So even with https://github.com/briansmith/webpki/issues/54 it will still crash Yes, sorry for the noise, that's right.