Benoit Daloze

Results 1300 comments of Benoit Daloze

So when moving all blocks outside of Lexer#advance in https://github.com/whitequark/parser/pull/902, I see this: ``` $ truffleruby --engine.TraceCompilation --experimental-options --engine.MaximumGraalGraphSize=180000 -Ilib -rparser/current -rbenchmark -e 'code=File.read("test/test_lexer.rb"); 300.times { p Benchmark.realtime { Parser::CurrentRuby.parse(code)...

> I've extracted A LOT in #901 and it's still not enough? I'm not sure that we are even able to reach minimum threshold that you mentioned, there are still...

There is https://github.com/e2/ruby_dep/pull/37 but the maintainer @e2 seems unresponsive (and this gem seems dead). I think I'll just automatically suppress those warnings on TruffleRuby.

https://github.com/oracle/truffleruby/commit/b88bae6a43687d2a40a8b8a76f7f315e261c4aaa should silence warnings from ruby_dep, so I think we can close this issue.

Given the current list of scripting/high-level dynamically-typed languages, I think Java wouldn't really fit here. Java is not used like Ruby/Python/JS/Lua is. That's just my opinion though. It would probably...

It's the same as for any other new runner, we need access to the runner from the ruby organization to build binaries, see https://github.com/ruby/setup-ruby/pull/494#issuecomment-1743537651 Until then linux-aarch64 will be detected...

^ Because https://github.com/actions/setup-ruby was not actively maintained and provided too little functionality to be practical (e.g. no way to specify Ruby x.y.z, only latest x.y and only 3-4 versions available).

@cb-krishnapatel The builds need to be tested automatically, so we need access to these runners and the builds must happen on GitHub runners to ensure it's exactly the same image...

@everplays While that diff is small it has the big disadvantage to have to compile CRuby from source every time (takes many minutes) and needing to manually install extra packages,...

@nobu Could you file a separate issue, with links to the failed workflows? This one is about linux-aarch64, not macOS.