Benoit Daloze

Results 1300 comments of Benoit Daloze

> I don't think it's an easy task. The library is written in Rust, C bindings are a wrapper around Rust lib (and it's pre-compiled for major platforms in Releases...

> Ah, as I understand you want to define these lambdas **in the `advance` method**, right? Then of course it should work. Right. Even though these lambdas would be part...

@iliabylich Nice, could you share a branch or PR with that change? I'd like to take a closer look if it compiles, which tier and also try it on bigger...

@iliabylich I've tried it (with `truffleruby-dev` and `truffleruby-22.3.0`) and for me it still fails, even though I do see the size reduction. Which command did you use? I used the...

With `-F0`, diff (on top of [your PR](https://github.com/whitequark/parser/pull/893)): ```diff diff --git a/Rakefile b/Rakefile index 74af484..c9e0391 100644 --- a/Rakefile +++ b/Rakefile @@ -152,7 +152,7 @@ task :changelog do end rule '.rb'...

`-T0` seems slightly bigger than `-F0` and is also significantly slower on TruffleRuby and CRuby. It also needs a bigger limit. ``` F0|Tier 1|Time 42349(6489+35861)ms|AST 15784|Inlined 0Y 192N|IR 32569/153201|CodeSize 693759...

Running on TruffleRuby JVM CE dev, with F0 and `--engine.MaximumGraalGraphSize=200000` (which we still need to address) it's almost as fast as CRuby and more stable performance: ``` $ truffleruby --engine.TraceCompilation...

> I'm not sure why this was merged so quickly without more testing. There was a lot of testing, I already spent almost a day on it. But indeed I...

FWIW, I wonder if Ragel is a good choice for `parser`'s lexer, it seems to generate more code and much bigger methods than other lexers such as [Ripper's lexer](https://github.com/oracle/truffleruby/blob/c9c717bf822deb4d5592eeedc05d1842bf72b88d/src/main/c/ripper/ripper.c#L16309-L17016) (707...

I remeasured today, with the latest `truffleruby-jvm-ce` built locally. There has been a bunch of changes notably I went Fedora 35->37, TruffleRuby is now built on JDK 11->17 (by default)...