Benoit Daloze
Benoit Daloze
I'll tentatively close this, it's unclear if worth the extra complexity and length in the cache key. `vendor/bundle` seems pretty standard.
Sharing my thoughts about this here too in addition to Slack: Users of the ABI version are e.g. gems testing ruby-head using ruby/setup-ruby. If they have many CI runs and...
> because what people can do is only clean and build when they hit ABI incompatibility. They'll probably hit a segfault in such cases, with the ABI version it's a...
> I want a release version is as similar as a development branch because such difference cause troubles multiple times in release process. I can't find it anymore but IIRC...
So I see 2 big problems if the ABI version is removed: * ruby/setup-ruby bundler caching for ruby-head will need to use the git commit as the ABI version. This...
> Not freezing the entire singleton class chain is expected, because at a certain point, the singleton class is shared. However, you can walk the the attached object chain for...
To clarify this changes the behavior of const_source_location in the thread doing the autoload (during the autoload) but not for other threads, correct? i.e. the constant's location is only visible...
> No. I made it to be consistent with the current behavior of `defined?` and `constants.include?` which both consider the constant defined from the other thread as soon as the...
The specs look good.
Normally this is all handled by RubyGems, a gem's extconf.rb should not manually copy the `.so` anywhere, just build the .so and let RubyGems do the rest.