Benoit Daloze

Results 1300 comments of Benoit Daloze

We need a use case for those, they seem optional

Now that there is TruffleString, asTruffleString() "works". asString() still fails, so probably we should do the same as asTruffleString().toString() or so. ``` irb irb(main):001:0> Truffle::Interop.as_truffle_string "é".b => "??" irb(main):002:0> Truffle::Interop.as_string...

Also select() seems limited to 1024 descriptors on Linux, so if `fd` happens to be higher it might just not work.

Yes, I used the same workaround, to use `gh` in https://github.com/ruby/truffleruby-dev-builder/blob/master/.github/workflows/build.yml It needs some extra things like setting GH_TOKEN/GITHUB_TOKEN and GH_REPO, otherwise it only works with a checkout of the...

I hit the same issue, and https://github.com/mxschmitt/action-tmate instead worked fine on macOS.

@hsbt Could you review this too? (if not, who should I ask?)

http://phash.org/licensing/ is very clear, there is no need for lawyer interpretation here, this gem must use GPL3: > pHash is open source software released under the [GNU General Public License...

Is this still an issue or could we close this?

I think we should close this as not planned. Removing MSYS2 from PATH is likely to cause far more problems than help, and Ruby on Windows basically relies on this...

With https://github.com/ruby/setup-ruby/pull/473 this action now gives instructions for how to make it work for self-hosted runners not matching a GitHub-hosted runner image.