Benoit Daloze comments

Results 1300 comments of


                                            Benoit Daloze

Write specs for new Ruby 2.7 features and changes

@andrykonchin I tried to keep the ones you checked after my last fix for links to issues. Should be fine but would be good if you can double-check.

Write specs for new Ruby 2.7 features and changes

Note for contributors: please mention here which item/checkbox you'd like to add specs for, in order to avoid duplicated work.

Write specs for new Ruby 2.7 features and changes

@lxxxvi In that case we could just add a new file and check `Array.should have_instance_method(:minmax)`, and a comment saying the behavior is tested in the `core/enumerable/minmax_spec.rb`. I don't see Arrays...

Write specs for new Ruby 2.7 features and changes

@kuei0221 Indeed, I now checked the box.

Write specs for new Ruby 2.7 features and changes

61/70 done, we're almost there!

Write specs for new Ruby 2.7 features and changes

I'll try to make one soon. It would be great to finish the last 5 items for this issue.

Write specs for new Ruby 2.7 features and changes

Only 2 items left under `C API updates` now.

Write specs for new Ruby 2.7 features and changes

Issue for Ruby 3.0 specs: https://github.com/ruby/spec/issues/823

Add many tests for core/io components

I'll try to review soon. Could you rebase on latest master? > This feels like a bug in MRI's implementation on windows which should be addressed. Could you report it...

Add many tests for core/io components

> what is the process to keep the test disabled only for Windows on older Ruby versions? Something like: ```ruby guard_not -> { platform_is :windows and ruby_version_is ""..."3.2" } do...