Benoit Daloze

Results 1300 comments of Benoit Daloze

@marcandre I wonder, do you have specs for Ractor? I know you wrote https://github.com/marcandre/backports/tree/master/lib/backports/ractor. Or maybe you used CRuby tests to check it?

This is surprising because for me this spec runs in like 5ms. I'd like to see another instance before bumping the timeout higher.

What is the motivation behind this change? AFAIK most users don't prefix with `Thread::` for `Queue` and `Mutex` (unless the code is quite old). I also don't think we can...

On CRuby I see: ``` $ ruby -e 'p Queue' Thread::Queue $ ruby -e 'p Mutex' Thread::Mutex ``` but on TruffleRuby: ``` $ ruby -e 'p Queue' Queue $ ruby...

I've merged a9430c7 since that change makes sense no matter what we do next.

@nobu Could you explain the motivation behind this change?

@nobu Thanks, I think we should change the canonical names instead so they represent the usages better: https://bugs.ruby-lang.org/issues/18256

Thank you for the PR. I decide to close this. AFAIK most usages by Ruby users are without the Thread:: prefix, and nesting seems to just make it harder to...

Good find, PR welcome. Ideally we'd find a way which is not racy and doesn't involve Thread#kill (tends to be messy with open IO).

https://github.com/jruby/jruby/pull/7157/commits/14945c6f30189dbef4237471be242d21b4ba85f1 doesn't quite work correctly. There was a trivial typo at https://github.com/jruby/jruby/pull/7157/commits/14945c6f30189dbef4237471be242d21b4ba85f1#diff-6c84b4cfeb3db4be2729c9368e853f9d13f61533d241defc6e68ae28bb011e88R26 which I fixed locally. But even after that there are transient failures like: ``` /bin/zsh -c chruby 2.6.9...