Benoit Daloze

Results 1300 comments of Benoit Daloze

I noticed the `deprecate_constant :SPELL_CHECKERS` so we would get a location if `Warning[:deprecated]` (non-default on 2.7.2+). So maybe no need to show the caller if we only warn when `Warning[:deprecated]`.

Maybe running after `export RUBYOPT=-W:deprecated` helps to find out.

This seems a serious issue, @westonplatter could you reply to this?

@mikecmpbll wrote: > do we know is it just the ruby 2.3.x or will it happen also for later rubies? just curious if upgrading ruby will resolve this, as I...

I'd like to see this as well. GitHub Discussions is becoming more widely used now, and this would be a great way to gets updates on Slack for GitHub Discussions.

Yes, this is very tempting but there are many problems with this approach. What if users want to run multiple commands, what if they expect a specific shell, what if...

I forgot to mention in my first reply. A general solution for this would be to extract a separate action to do the bundler caching. And then one can do...

Right, so we need to make the value of `working-directory:` part of the cache key. Until then, a workaround is to use `cache-version: ` to ensure a separate cache per...

I think that wouldn't work, there will be most likely absolute paths e.g. embedded in built C extensions.

Right, so the Gemfile.lock is the same no matter which `with`/`without` groups are specified. One concern here is that it might be useful to install all gems in a first...