Benoit Daloze

Results 1300 comments of Benoit Daloze

> Our problem occurs when parsing a rather long text file (118MB) and causes an error. The encoding of the String should then be set as non-binary (e.g., `File.read` instead...

@fniephaus We do test against the TCK, but probably we don't have an example for a binary Ruby String with non-7-bit characters. Making binary Ruby String with non-7-bit characters not...

> what about converting binary strings to byte[] and return a new Java string for that array? It's not possible to "return a new Java string for that array" without...

This is an interesting question to revisit now that TruffleString is being worked on. We should check what is the behavior if one tries to get a j.l.String from a...

Yes, it's the same as #2053. Ruby 2.7.2 doesn't include a recent enough version of JSON to fix it. So we have 4 choices: * Update to latest JSON, but...

The index is not a PE constant here, hence the field read is still in the code and not folded. And indeed there is nothing tracking "are all entries non-null"....

I guess one possible way is PE would take a private copy of that array, and somehow embed it in the generated code (if it's not too big, 100 elements...

> But I fear the cost of the additional indirection That would only be a cost in the interpreter, in PE code it'd be the same, at least for this...

One trade-off in this case though with that wrapper is we'd have a class check when reading to cast Object -> LeafRope. Probably it's avoidable if we also pass the...