Yuri Mizushima
Yuri Mizushima
rerun failure checks
@eolivelli Addressed your comments. PTAL.
> Also: https://github.com/apache/bookkeeper/pull/3359 Thank you for sharing. I'll check it first.
@dlg99 https://github.com/apache/bookkeeper/pull/2931#issuecomment-1190559164 Sorry for the late reply. I've checked https://github.com/apache/bookkeeper/pull/3359#pullrequestreview-1061219674 . The approach (using autorecovery) sounds better. If it was merged and still has the above issue, I'll rebase to...
@horizonzy > I notice that the implements didn’t handle the bookie which already shutdown. The shutdown bookie will be as the defaultRack, can we replace it? Currently, maybe, we can't...
>> I notice that the implements didn’t handle the bookie which already shutdown. The shutdown bookie will be as the defaultRack, can we replace it? > > Currently, maybe, we...
In my understanding, currently, defaultRack of Rackaware is `/default-rack`. So we should consider about it if use it. https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L138 https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L234-L248 >> However, it is not expected of me. I'll modify...
And what about the ~default rack~ shutdown bookies? https://github.com/apache/bookkeeper/pull/2931#pullrequestreview-1062016018 If it is being addressed, please let me know where it is.
> Now we add the shutdown bookies to excludes nodes to replace it. Just confirm, are you mentioned here? https://github.com/horizonzy/bookkeeper/blob/6ef1e2aa8ac0780bd8199b360e840506cbc85e5d/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L1101-L1105